[SPARK-26219][CORE] Executor summary should get updated for failure jobs in the history server UI #23181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahidki31
changed the title
shahidki31
changed the title
|
Test build #99466 has finished for PR 23181 at commit
|
|
Jenkins, retest this please |
|
cc @vanzin Kindly review |
shahidki31
changed the title
|
Test build #99468 has finished for PR 23181 at commit
|
|
Jenkins, retest this please |
|
Test build #99482 has finished for PR 23181 at commit
|
|
Jenkins, retest this please |
|
Test build #99492 has finished for PR 23181 at commit
|
vanzin
reviewed
Nov 30, 2018
| val stage = new StageInfo(1, 0, "stage", 4, Nil, Nil, "details") | ||
| listener.onJobStart(SparkListenerJobStart(1, time, Seq(stage), null)) | ||
| listener.onStageSubmitted(SparkListenerStageSubmitted(stage, new Properties())) | ||
| isLiveSeq.foreach { live: Boolean => |
There was a problem hiding this comment.
When doing things like this I prefer to invert the logic.
Seq(true, false).foreach { live =>
test(s"blah blah blah (live = $live)") {
}
}
There was a problem hiding this comment.
Thanks. Updated.
| listener.onStageSubmitted(SparkListenerStageSubmitted(stage, new Properties())) | ||
| isLiveSeq.foreach { live: Boolean => | ||
| val testConf = if (live) { | ||
| conf.clone.set(LIVE_ENTITY_UPDATE_PERIOD, Long.MaxValue) |
|
Jenkins, retest this please |
|
Test build #99524 has finished for PR 23181 at commit
|
|
Test build #99523 has finished for PR 23181 at commit
|
|
Merging to master / 2.4. |
|
This didn't merge cleanly to 2.4, please open a PR against that branch if you want it there. |
|
Thanks @vanzin. I will open a PR in 2.4 branch |
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
…obs in the history server UI The root cause of the problem is, whenever the taskEnd event comes after stageCompleted event, execSummary is updating only for live UI. we need to update for history UI too. To see the previous discussion, refer: PR for apache#23038, https://issues.apache.org/jira/browse/SPARK-26100. Added UT. Manually verified Test step to reproduce: ``` bin/spark-shell --master yarn --conf spark.executor.instances=3 sc.parallelize(1 to 10000, 10).map{ x => throw new RuntimeException("Bad executor")}.collect() ``` Open Executors page from the History UI Before patch:  After patch:  Closes apache#23181 from shahidki31/executorUpdate. Authored-by: Shahid <shahidki31@gmail.com> Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com>
kai-chi
pushed a commit
to kai-chi/spark
that referenced
this pull request
Jul 23, 2019
…or failure jobs in the history server UI Back port the commit apache#23181 into Spark2.4 branch Added UT Closes apache#23191 from shahidki31/branch-2.4. Authored-by: Shahid <shahidki31@gmail.com> Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com>
kai-chi
pushed a commit
to kai-chi/spark
that referenced
this pull request
Aug 1, 2019
…or failure jobs in the history server UI Back port the commit apache#23181 into Spark2.4 branch Added UT Closes apache#23191 from shahidki31/branch-2.4. Authored-by: Shahid <shahidki31@gmail.com> Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com>
zhongjinhan
pushed a commit
to zhongjinhan/spark-1
that referenced
this pull request
Sep 3, 2019
…or failure jobs in the history server UI Back port the commit apache/spark#23181 into Spark2.4 branch Added UT Closes #23191 from shahidki31/branch-2.4. Authored-by: Shahid <shahidki31@gmail.com> Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com> (cherry picked from commit 90fcd12)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The root cause of the problem is, whenever the taskEnd event comes after stageCompleted event, execSummary is updating only for live UI. we need to update for history UI too.
To see the previous discussion, refer: PR for #23038, https://issues.apache.org/jira/browse/SPARK-26100.
How was this patch tested?
Added UT. Manually verified
Test step to reproduce:
Open Executors page from the History UI
Before patch:
After patch:
